Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
C cnyes-dfp
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Jira
    • Jira
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • share
  • cnyes-dfp
  • Merge requests
  • !3

Merged
Created Nov 28, 2018 by jameslu@jamesluOwner

replace clear by destroySlots

  • Overview 1
  • Commits 1
  • Changes 4

Created by: Anonymous

**What
**廣告部反應包版廣告在切換新聞(client side render)後廣告會消失.
(發生問題的廣告為 Desktop aside middle: /1018855/cnyes_news_aside_middle)

**Why
**目前切換頁面不會顯示重複廣告, 所有委刊項各播一次就開始播聯播網, 沒有串聯播網的 adUnit 就不會顯示廣告 (slotRenderEnded event.isEmpty === true)

How
DFPProvider 目前 re-render adSlot 時是執行 clear -> refresh,
adgeek & google 官方文件(https://support.google.com/admanager/answer/183281) 均建議使用 destroySlots,
與廣告部討論後決定調整 DFPProvider 設定,
因 destroySlots 會清除所有紀錄, 所以每次切換頁面能拿到重複的廣告,
如有多個委刊項就依設定由 google 分派

‌

Reference:
https://developers.google.com/doubleclick-gpt/reference#googletag.destroySlots
https://developers.google.com/doubleclick-gpt/reference#googletag.PubAdsService_clear

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: feature/replace_clear_by_destroy